Apply rector changes#60102
Open
nextcloud-command wants to merge 1 commit intomasterfrom
Open
Conversation
nextcloud-command
requested review from
Altahrim,
artonge,
leftybournes and
salmart-dev
and removed request for
a team
joshtrichards
approved these changes
May 5, 2026
Signed-off-by: GitHub <noreply@github.com>
joshtrichards
force-pushed
the
automated/noid/rector-changes
branch
from
c8c295b to
ddb51d9
Compare
icewind1991
approved these changes
May 5, 2026
Member
|
This is a broader issue that I suspect came from some other psalm changes:
We likely don't want to use named arguments for these; phpunit discourages it and it's unnecesary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated changes by create-pull-request GitHub action